-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add basic benchmark suite to C library #393
Conversation
Can you show what the results look like? |
This is from the CI run (so timings are maybe meaningless), but the output looks like:
|
src/nanoarrow/array_benchmark.cc
Outdated
BENCHMARK(BM_ArrayViewGetIntUnsafeInt16); | ||
BENCHMARK(BM_ArrayViewGetIntUnsafeInt32); | ||
BENCHMARK(BM_ArrayViewGetIntUnsafeInt64); | ||
BENCHMARK(BM_ArrayViewGetIntUnsafeInt64CheckNull); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm in Arrow C++ we don't start the benchmarks with BM_
. Is that necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! I think it was rather contagious copy/paste from the first example in the benchmark library README 😬
Thank you! This looks fine to me. |
This PR adds an initial set of benchmarks covering some realistic usage patterns. The general approach is to use doxygen comments to document the benchmarks, which will run against the released version and the previous version. I'm not sure exactly what the output format will be but I'd like the benchmarks to be written in such a way that there's a path to programatically generating a report (maybe using conbench, maybe just a Quarto document). Work in progress!
This PR adds an initial set of benchmarks covering some realistic usage patterns. The general approach is to use doxygen comments to document the benchmarks, which will run against the released version and the previous version. I'm not sure exactly what the output format will be but I'd like the benchmarks to be written in such a way that there's a path to programatically generating a report (maybe using conbench, maybe just a Quarto document).
Work in progress!