Skip to content

Commit

Permalink
Hide implicit optional dependency features in arrow-flight (#6806)
Browse files Browse the repository at this point in the history
A dependency X marked `optional = true` implicitly defines a feature X.
Docs: https://doc.rust-lang.org/cargo/reference/features.html#optional-dependencies
This can be seen at https://docs.rs/crate/arrow-flight/53.3.0/features

The optional dependencies were not meant to be standalone features
though. Using `dep:` in the `[features]` section is supposed to disable
this. It is enough to use `dep:` once. It's used for every optional
dependency for consistency.
  • Loading branch information
findepi authored Nov 27, 2024
1 parent 93e6749 commit 088e5db
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions arrow-flight/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,11 @@ all-features = true

[features]
default = []
flight-sql-experimental = ["arrow-arith", "arrow-data", "arrow-ord", "arrow-row", "arrow-select", "arrow-string", "once_cell"]
flight-sql-experimental = ["dep:arrow-arith", "dep:arrow-data", "dep:arrow-ord", "dep:arrow-row", "dep:arrow-select", "dep:arrow-string", "dep:once_cell"]
tls = ["tonic/tls"]

# Enable CLI tools
cli = ["anyhow", "arrow-array/chrono-tz", "arrow-cast/prettyprint", "clap", "tracing-log", "tracing-subscriber", "tonic/tls-webpki-roots"]
cli = ["dep:anyhow", "arrow-array/chrono-tz", "arrow-cast/prettyprint", "dep:clap", "dep:tracing-log", "dep:tracing-subscriber", "tonic/tls-webpki-roots"]

[dev-dependencies]
arrow-cast = { workspace = true, features = ["prettyprint"] }
Expand Down

0 comments on commit 088e5db

Please sign in to comment.