Skip to content

Commit

Permalink
Tweak Private Sbbf::new_with_ndv_fpp Documentation (#5718)
Browse files Browse the repository at this point in the history
* Solve Inconsistency

* Solve inconsistency

* Solve inconsistency
  • Loading branch information
YichiZhang0613 authored May 4, 2024
1 parent d9206ba commit 0d0c02e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion parquet/src/bloom_filter/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ fn num_of_bits_from_ndv_fpp(ndv: u64, fpp: f64) -> usize {

impl Sbbf {
/// Create a new [Sbbf] with given number of distinct values and false positive probability.
/// Will panic if `fpp` is greater than 1.0 or less than 0.0.
/// Will return an error if `fpp` is greater than or equal to 1.0 or less than 0.0.
pub(crate) fn new_with_ndv_fpp(ndv: u64, fpp: f64) -> Result<Self, ParquetError> {
if !(0.0..1.0).contains(&fpp) {
return Err(ParquetError::General(format!(
Expand Down

0 comments on commit 0d0c02e

Please sign in to comment.