Propagate error instead of panic for take_bytes (#5395)

* Propagate Error instead of panic * Improve error message
apache · Feb 13, 2024 · 1b06d78 · 1b06d78
1 parent c9029c5
commit 1b06d78
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/arrow-select/src/take.rs b/arrow-select/src/take.rs
@@ -420,7 +420,11 @@ fn take_bytes<T: ByteArrayType, IndexType: ArrowPrimitiveType>(
         nulls = Some(null_buf.into())
     }
 
-    T::Offset::from_usize(values.len()).expect("offset overflow");
+    T::Offset::from_usize(values.len()).ok_or(ArrowError::ComputeError(format!(
+        "Offset overflow for {}BinaryArray: {}",
+        T::Offset::PREFIX,
+        values.len()
+    )))?;
 
     let array_data = ArrayData::builder(T::DATA_TYPE)
         .len(data_len)