Using a builder, per review suggestion

apache · Dec 5, 2023 · 1c72fa2 · 1c72fa2
1 parent 0c1bb9c
commit 1c72fa2
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/arrow-select/src/take.rs b/arrow-select/src/take.rs
@@ -19,7 +19,7 @@
 
 use std::sync::Arc;
 
-use arrow_array::builder::BufferBuilder;
+use arrow_array::builder::{BufferBuilder, UInt32Builder};
 use arrow_array::cast::AsArray;
 use arrow_array::types::*;
 use arrow_array::*;
@@ -689,7 +689,7 @@ fn take_value_indices_from_fixed_size_list<IndexType>(
 where
     IndexType: ArrowPrimitiveType,
 {
-    let mut values = Vec::with_capacity(length as usize * indices.len());
+    let mut values = UInt32Builder::with_capacity(length as usize * indices.len());
 
     for i in 0..indices.len() {
         if indices.is_valid(i) {
@@ -705,7 +705,7 @@ where
         }
     }
 
-    Ok(PrimitiveArray::<UInt32Type>::from(values))
+    Ok(values.finish())
 }
 
 /// To avoid generating take implementations for every index type, instead we