Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Will Jones <[email protected]>
  • Loading branch information
westonpace and wjones127 authored Dec 5, 2023
1 parent 932e0df commit 6bf9562
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions arrow-select/src/take.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1989,7 +1989,7 @@ mod tests {

#[test]
fn test_take_fixed_size_list_null_indices() {
let indices = Int32Array::new(vec![0, 1].into(), Some(NullBuffer::from(vec![true, false])));
let indices = Int32Array::from_iter([Some(1), None]);
let values = Arc::new(Int32Array::from(vec![0, 1, 2, 3]));
let arr_field = Arc::new(Field::new("item", values.data_type().clone(), true));
let values = FixedSizeListArray::try_new(arr_field, 2, values, None).unwrap();
Expand All @@ -1999,9 +1999,8 @@ mod tests {
.as_fixed_size_list()
.values()
.as_primitive::<Int32Type>()
.into_iter()
.collect::<Vec<_>>();
assert_eq!(&values, &[Some(0), Some(1), None, None])
.values();
assert_eq!(values, &[Some(0), Some(1), None, None])
}

#[test]
Expand Down

0 comments on commit 6bf9562

Please sign in to comment.