More trivial implementation of Box<dyn AsyncArrowWriter> and `Box<d…

…yn AsyncArrowReader>` (#6748) * Wilder implementor of Box<dyn AsyncArrowWriter> and Box<dyn AsyncArrowReader> in parquet * Update parquet/src/arrow/async_reader/mod.rs Co-authored-by: Jay Zhan <[email protected]> * remove empty line --------- Co-authored-by: Jay Zhan <[email protected]>
apache · Nov 20, 2024 · 70f415d · 70f415d
1 parent 390f0ba
commit 70f415d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/parquet/src/arrow/async_reader/mod.rs b/parquet/src/arrow/async_reader/mod.rs
@@ -158,7 +158,8 @@ pub trait AsyncFileReader: Send {
     fn get_metadata(&mut self) -> BoxFuture<'_, Result<Arc<ParquetMetaData>>>;
 }
 
-impl AsyncFileReader for Box<dyn AsyncFileReader> {
+/// This allows Box<dyn AsyncFileReader + '_> to be used as an AsyncFileReader,
+impl<'reader> AsyncFileReader for Box<dyn AsyncFileReader + 'reader> {
     fn get_bytes(&mut self, range: Range<usize>) -> BoxFuture<'_, Result<Bytes>> {
         self.as_mut().get_bytes(range)
     }

diff --git a/parquet/src/arrow/async_writer/mod.rs b/parquet/src/arrow/async_writer/mod.rs
@@ -89,7 +89,7 @@ pub trait AsyncFileWriter: Send {
     fn complete(&mut self) -> BoxFuture<'_, Result<()>>;
 }
 
-impl AsyncFileWriter for Box<dyn AsyncFileWriter> {
+impl<'writer> AsyncFileWriter for Box<dyn AsyncFileWriter + 'writer> {
     fn write(&mut self, bs: Bytes) -> BoxFuture<'_, Result<()>> {
         self.as_mut().write(bs)
     }