Skip to content

Commit

Permalink
Disable MIRI check until it runs cleanly on CI (#360)
Browse files Browse the repository at this point in the history
  • Loading branch information
alamb authored May 26, 2021
1 parent 94a82cd commit 74d5957
Showing 1 changed file with 37 additions and 34 deletions.
71 changes: 37 additions & 34 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -230,40 +230,43 @@ jobs:
export CARGO_TARGET_DIR="/github/home/target"
cargo clippy --all-targets --workspace -- -D warnings -A clippy::redundant_field_names
miri-checks:
name: MIRI
runs-on: ubuntu-latest
strategy:
matrix:
arch: [amd64]
rust: [nightly-2021-03-24]
steps:
- uses: actions/checkout@v2
with:
submodules: true
- uses: actions/cache@v2
with:
path: |
~/.cargo/registry
~/.cargo/git
target
key: ${{ runner.os }}-cargo-miri-${{ hashFiles('**/Cargo.lock') }}
- name: Setup Rust toolchain
run: |
rustup toolchain install ${{ matrix.rust }}
rustup default ${{ matrix.rust }}
rustup component add rustfmt clippy miri
- name: Run Miri Checks
env:
RUST_BACKTRACE: full
RUST_LOG: 'trace'
run: |
export MIRIFLAGS="-Zmiri-disable-isolation"
cargo miri setup
cargo clean
# Currently only the arrow crate is tested with miri
# IO related tests and some unsupported tests are skipped
cargo miri test -p arrow -- --skip csv --skip ipc --skip json
# MIRI checks are disabled until they runs cleanly:
# https://github.com/apache/arrow-rs/issues/345
#
# miri-checks:
# name: MIRI
# runs-on: ubuntu-latest
# strategy:
# matrix:
# arch: [amd64]
# rust: [nightly-2021-03-24]
# steps:
# - uses: actions/checkout@v2
# with:
# submodules: true
# - uses: actions/cache@v2
# with:
# path: |
# ~/.cargo/registry
# ~/.cargo/git
# target
# key: ${{ runner.os }}-cargo-miri-${{ hashFiles('**/Cargo.lock') }}
# - name: Setup Rust toolchain
# run: |
# rustup toolchain install ${{ matrix.rust }}
# rustup default ${{ matrix.rust }}
# rustup component add rustfmt clippy miri
# - name: Run Miri Checks
# env:
# RUST_BACKTRACE: full
# RUST_LOG: 'trace'
# run: |
# export MIRIFLAGS="-Zmiri-disable-isolation"
# cargo miri setup
# cargo clean
# # Currently only the arrow crate is tested with miri
# # IO related tests and some unsupported tests are skipped
# cargo miri test -p arrow -- --skip csv --skip ipc --skip json || true

lint:
name: Lint
Expand Down

0 comments on commit 74d5957

Please sign in to comment.