Enable unused_crate_dependencies Rust lint

apache · Nov 26, 2024 · 75a1865 · 75a1865
1 parent 0ce55f8
commit 75a1865
Show file tree

Hide file tree

Showing 25 changed files with 79 additions and 0 deletions.
diff --git a/Cargo.toml b/Cargo.toml
@@ -94,3 +94,8 @@ arrow-string = { version = "53.3.0", path = "./arrow-string" }
 parquet = { version = "53.3.0", path = "./parquet", default-features = false }
 
 chrono = { version = "0.4.34", default-features = false, features = ["clock"] }
+
+[workspace.lints.rust]
+# Using warn level for Rust lints allows compilation within IDE, while still
+# enforcing lints on CI.
+unused_crate_dependencies = "warn"
diff --git a/arrow-arith/Cargo.toml b/arrow-arith/Cargo.toml
@@ -28,6 +28,9 @@ include = { workspace = true }
 edition = { workspace = true }
 rust-version = { workspace = true }
 
+[lints]
+workspace = true
+
 [lib]
 name = "arrow_arith"
 path = "src/lib.rs"

diff --git a/arrow-array/Cargo.toml b/arrow-array/Cargo.toml
@@ -28,6 +28,9 @@ include = { workspace = true }
 edition = { workspace = true }
 rust-version = { workspace = true }
 
+[lints]
+workspace = true
+
 [lib]
 name = "arrow_array"
 path = "src/lib.rs"

diff --git a/arrow-avro/Cargo.toml b/arrow-avro/Cargo.toml
@@ -28,6 +28,9 @@ include = { workspace = true }
 edition = { workspace = true }
 rust-version = { workspace = true }
 
+[lints]
+workspace = true
+
 [lib]
 name = "arrow_avro"
 path = "src/lib.rs"

diff --git a/arrow-buffer/Cargo.toml b/arrow-buffer/Cargo.toml
@@ -28,6 +28,9 @@ include = { workspace = true }
 edition = { workspace = true }
 rust-version = { workspace = true }
 
+[lints]
+workspace = true
+
 [lib]
 name = "arrow_buffer"
 path = "src/lib.rs"

diff --git a/arrow-cast/Cargo.toml b/arrow-cast/Cargo.toml
@@ -28,6 +28,9 @@ include = { workspace = true }
 edition = { workspace = true }
 rust-version = { workspace = true }
 
+[lints]
+workspace = true
+
 [lib]
 name = "arrow_cast"
 path = "src/lib.rs"

diff --git a/arrow-csv/Cargo.toml b/arrow-csv/Cargo.toml
@@ -28,6 +28,9 @@ include = { workspace = true }
 edition = { workspace = true }
 rust-version = { workspace = true }
 
+[lints]
+workspace = true
+
 [lib]
 name = "arrow_csv"
 path = "src/lib.rs"

diff --git a/arrow-data/Cargo.toml b/arrow-data/Cargo.toml
@@ -28,6 +28,9 @@ include = { workspace = true }
 edition = { workspace = true }
 rust-version = { workspace = true }
 
+[lints]
+workspace = true
+
 [lib]
 name = "arrow_data"
 path = "src/lib.rs"

diff --git a/arrow-flight/Cargo.toml b/arrow-flight/Cargo.toml
@@ -26,6 +26,9 @@ homepage = { workspace = true }
 repository = { workspace = true }
 license = { workspace = true }
 
+[lints]
+workspace = true
+
 [dependencies]
 arrow-arith = { workspace = true, optional = true }
 arrow-array = { workspace = true }

diff --git a/arrow-flight/gen/Cargo.toml b/arrow-flight/gen/Cargo.toml
@@ -27,6 +27,9 @@ repository = { workspace = true }
 license = { workspace = true }
 publish = false
 
+[lints]
+workspace = true
+
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
 [dependencies]

diff --git a/arrow-integration-test/Cargo.toml b/arrow-integration-test/Cargo.toml
@@ -28,6 +28,9 @@ include = { workspace = true }
 edition = { workspace = true }
 rust-version = { workspace = true }
 
+[lints]
+workspace = true
+
 [lib]
 name = "arrow_integration_test"
 path = "src/lib.rs"

diff --git a/arrow-integration-testing/Cargo.toml b/arrow-integration-testing/Cargo.toml
@@ -27,6 +27,9 @@ edition = { workspace = true }
 publish = false
 rust-version = { workspace = true }
 
+[lints]
+workspace = true
+
 [lib]
 crate-type = ["lib", "cdylib"]
 

diff --git a/arrow-ipc/Cargo.toml b/arrow-ipc/Cargo.toml
@@ -28,6 +28,9 @@ include = { workspace = true }
 edition = { workspace = true }
 rust-version = { workspace = true }
 
+[lints]
+workspace = true
+
 [lib]
 name = "arrow_ipc"
 path = "src/lib.rs"

diff --git a/arrow-json/Cargo.toml b/arrow-json/Cargo.toml
@@ -28,6 +28,9 @@ include = { workspace = true }
 edition = { workspace = true }
 rust-version = { workspace = true }
 
+[lints]
+workspace = true
+
 [lib]
 name = "arrow_json"
 path = "src/lib.rs"

diff --git a/arrow-ord/Cargo.toml b/arrow-ord/Cargo.toml
@@ -28,6 +28,9 @@ include = { workspace = true }
 edition = { workspace = true }
 rust-version = { workspace = true }
 
+[lints]
+workspace = true
+
 [lib]
 name = "arrow_ord"
 path = "src/lib.rs"

diff --git a/arrow-pyarrow-integration-testing/Cargo.toml b/arrow-pyarrow-integration-testing/Cargo.toml
@@ -28,6 +28,9 @@ edition = "2021"
 rust-version = "1.62"
 publish = false
 
+[lints]
+workspace = true
+
 [lib]
 name = "arrow_pyarrow_integration_testing"
 crate-type = ["cdylib"]

diff --git a/arrow-row/Cargo.toml b/arrow-row/Cargo.toml
@@ -28,6 +28,9 @@ include = { workspace = true }
 edition = { workspace = true }
 rust-version = { workspace = true }
 
+[lints]
+workspace = true
+
 [lib]
 name = "arrow_row"
 path = "src/lib.rs"

diff --git a/arrow-schema/Cargo.toml b/arrow-schema/Cargo.toml
@@ -28,6 +28,9 @@ include = { workspace = true }
 edition = { workspace = true }
 rust-version = { workspace = true }
 
+[lints]
+workspace = true
+
 [lib]
 name = "arrow_schema"
 path = "src/lib.rs"

diff --git a/arrow-select/Cargo.toml b/arrow-select/Cargo.toml
@@ -28,6 +28,9 @@ include = { workspace = true }
 edition = { workspace = true }
 rust-version = { workspace = true }
 
+[lints]
+workspace = true
+
 [lib]
 name = "arrow_select"
 path = "src/lib.rs"

diff --git a/arrow-string/Cargo.toml b/arrow-string/Cargo.toml
@@ -28,6 +28,9 @@ include = { workspace = true }
 edition = { workspace = true }
 rust-version = { workspace = true }
 
+[lints]
+workspace = true
+
 [lib]
 name = "arrow_string"
 path = "src/lib.rs"

diff --git a/arrow/Cargo.toml b/arrow/Cargo.toml
@@ -33,6 +33,9 @@ include = [
 edition = { workspace = true }
 rust-version = "1.70.0"
 
+[lints]
+workspace = true
+
 [lib]
 name = "arrow"
 path = "src/lib.rs"

diff --git a/object_store/Cargo.toml b/object_store/Cargo.toml
@@ -26,6 +26,11 @@ keywords = ["object", "storage", "cloud"]
 repository = "https://github.com/apache/arrow-rs/tree/master/object_store"
 rust-version = "1.64.0"
 
+[lints.rust]
+# Using warn level for Rust lints allows compilation within IDE, while still
+# enforcing lints on CI.
+unused_crate_dependencies = "warn"
+
 [package.metadata.docs.rs]
 all-features = true
 

diff --git a/parquet/Cargo.toml b/parquet/Cargo.toml
@@ -28,6 +28,9 @@ readme = "README.md"
 edition = { workspace = true }
 rust-version = "1.70.0"
 
+[lints]
+workspace = true
+
 [target.'cfg(target_arch = "wasm32")'.dependencies]
 ahash = { version = "0.8", default-features = false, features = ["compile-time-rng"] }
 

diff --git a/parquet_derive/Cargo.toml b/parquet_derive/Cargo.toml
@@ -28,6 +28,9 @@ readme = "README.md"
 edition = { workspace = true }
 rust-version = { workspace = true }
 
+[lints]
+workspace = true
+
 [lib]
 proc-macro = true
 

diff --git a/parquet_derive_test/Cargo.toml b/parquet_derive_test/Cargo.toml
@@ -28,6 +28,9 @@ edition = { workspace = true }
 publish = false
 rust-version = { workspace = true }
 
+[lints]
+workspace = true
+
 [dependencies]
 parquet = { workspace = true }
 parquet_derive = { path = "../parquet_derive", default-features = false }