Merge pull request #10 from mpurins-coralogix/v22-with-page-skipping-fix

Update master to mpurins-coralogix/arrow-rs v22-with-page-skipping-fix branch

.github/ISSUE_TEMPLATE/bug_report.md

@@ -8,13 +8,21 @@ assignees: ''
 ---
 
 **Describe the bug**
+<!--
 A clear and concise description of what the bug is.
+-->
 
 **To Reproduce**
+<!--
 Steps to reproduce the behavior:
+-->
 
 **Expected behavior**
+<!--
 A clear and concise description of what you expected to happen.
+-->
 
 **Additional context**
+<!--
 Add any other context about the problem here.
+-->

.github/ISSUE_TEMPLATE/feature_request.md

@@ -8,14 +8,22 @@ assignees: ''
 ---
 
 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
+<!--
 A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] 
 (This section helps Arrow developers understand the context and *why* for this feature, in addition to  the *what*)
+-->
 
 **Describe the solution you'd like**
+<!--
 A clear and concise description of what you want to happen.
+-->
 
 **Describe alternatives you've considered**
+<!--
 A clear and concise description of any alternative solutions or features you've considered.
+-->
 
 **Additional context**
+<!--
 Add any other context or screenshots about the feature request here.
+-->

.github/ISSUE_TEMPLATE/question.md

@@ -8,10 +8,16 @@ assignees: ''
 ---
 
 **Which part is this question about**
+<!--
 Is it code base, library api, documentation or some other part?
+-->
 
 **Describe your question**
+<!--
 A clear and concise description of what the question is.
+-->
 
 **Additional context**
+<!--
 Add any other context about the problem here.
+-->

.github/actions/setup-builder/action.yaml

@@ -42,14 +42,6 @@ runs:
     - name: Generate lockfile
       shell: bash
       run: cargo fetch
-    - name: Cache Rust dependencies
-      uses: actions/cache@v3
-      with:
-        # these represent compiled steps of both dependencies and arrow
-        # and thus are specific for a particular OS, arch and rust version.
-        path: /github/home/target
-        key: ${{ runner.os }}-${{ runner.arch }}-target-cache3-${{ inputs.rust-version }}-${{ hashFiles('**/Cargo.lock') }}
-        restore-keys: ${{ runner.os }}-${{ runner.arch }}-target-cache3-${{ inputs.rust-version }}-
     - name: Install Build Dependencies
       shell: bash
       run: |

.github/dependabot.yml

@@ -7,3 +7,9 @@ updates:
     open-pull-requests-limit: 10
     target-branch: master
     labels: [auto-dependencies]
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "daily"
+    open-pull-requests-limit: 10
+    labels: [auto-dependencies]

.github/pull_request_template.md

@@ -1,28 +1,28 @@
 # Which issue does this PR close?
 
-<!---
+<!--
 We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
 -->
 
 Closes #.
 
 # Rationale for this change
 
- <!---
- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
- Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
+<!--
+Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
+Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
 -->
 
 # What changes are included in this PR?
 
-<!---
+<!--
 There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
 -->
 
 # Are there any user-facing changes?
 
 
-<!---
+<!--
 If there are user-facing changes then we may require documentation to be updated before approving the PR.
 -->
 

.github/workflows/README.md

@@ -0,0 +1,25 @@
+<!---
+  Licensed to the Apache Software Foundation (ASF) under one
+  or more contributor license agreements.  See the NOTICE file
+  distributed with this work for additional information
+  regarding copyright ownership.  The ASF licenses this file
+  to you under the Apache License, Version 2.0 (the
+  "License"); you may not use this file except in compliance
+  with the License.  You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing,
+  software distributed under the License is distributed on an
+  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+  KIND, either express or implied.  See the License for the
+  specific language governing permissions and limitations
+  under the License.
+-->
+
+The CI is structured so most tests are run in specific workflows:
+`arrow.yml` for `arrow`, `parquet.yml` for `parquet` and so on.
+
+The basic idea is to run all tests on pushes to master (to ensure we
+keep master green) but run only the individual workflows on PRs that
+change files that could affect them.

.github/workflows/arrow.yml

@@ -0,0 +1,177 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# tests for arrow crate
+name: arrow
+
+on:
+  # always trigger
+  push:
+    branches:
+      - master
+  pull_request:
+    paths:
+      - arrow/**
+      - .github/**
+
+jobs:
+
+  # test the crate
+  linux-test:
+    name: Test
+    runs-on: ubuntu-latest
+    container:
+      image: amd64/rust
+      env:
+        # Disable full debug symbol generation to speed up CI build and keep memory down
+        # "1" means line tables only, which is useful for panic tracebacks.
+        RUSTFLAGS: "-C debuginfo=1"
+    steps:
+      - uses: actions/checkout@v3
+        with:
+          submodules: true
+      - name: Setup Rust toolchain
+        uses: ./.github/actions/setup-builder
+        with:
+          rust-version: stable
+      - name: Test
+        run: |
+          cargo test -p arrow
+      - name: Test --features=force_validate,prettyprint,ipc_compression,ffi,dyn_cmp_dict
+        run: |
+          cargo test -p arrow --features=force_validate,prettyprint,ipc_compression,ffi,dyn_cmp_dict
+      - name: Run examples
+        run: |
+          # Test arrow examples
+          cargo run --example builders
+          cargo run --example dynamic_types
+          cargo run --example read_csv
+          cargo run --example read_csv_infer_schema
+      - name: Run non-archery based integration-tests
+        run: cargo test -p arrow-integration-testing
+
+  # test compilaton features
+  linux-features:
+    name: Check Compilation
+    runs-on: ubuntu-latest
+    container:
+      image: amd64/rust
+      env:
+        # Disable full debug symbol generation to speed up CI build and keep memory down
+        # "1" means line tables only, which is useful for panic tracebacks.
+        RUSTFLAGS: "-C debuginfo=1"
+    steps:
+      - uses: actions/checkout@v3
+        with:
+          submodules: true
+      - name: Setup Rust toolchain
+        uses: ./.github/actions/setup-builder
+        with:
+          rust-version: stable
+      - name: Check compilation
+        run: |
+          cargo check -p arrow
+      - name: Check compilation --no-default-features
+        run: |
+          cargo check -p arrow --no-default-features
+      - name: Check compilation --all-targets
+        run: |
+          cargo check -p arrow --all-targets
+      - name: Check compilation --no-default-features --all-targets
+        run: |
+          cargo check -p arrow --no-default-features --all-targets
+      - name: Check compilation --no-default-features --all-targets --features test_utils
+        run: |
+          cargo check -p arrow --no-default-features --all-targets --features test_utils
+
+  # test the --features "simd" of the arrow crate. This requires nightly Rust.
+  linux-test-simd:
+    name: Test SIMD on AMD64 Rust ${{ matrix.rust }}
+    runs-on: ubuntu-latest
+    container:
+      image: amd64/rust
+      env:
+        # Disable full debug symbol generation to speed up CI build and keep memory down
+        # "1" means line tables only, which is useful for panic tracebacks.
+        RUSTFLAGS: "-C debuginfo=1"
+    steps:
+      - uses: actions/checkout@v3
+        with:
+          submodules: true
+      - name: Setup Rust toolchain
+        uses: ./.github/actions/setup-builder
+        with:
+          rust-version: nightly
+      - name: Run tests --features "simd"
+        run: |
+          cargo test -p arrow --features "simd"
+      - name: Check compilation --features "simd"
+        run: |
+          cargo check -p arrow --features simd
+      - name: Check compilation --features simd --all-targets
+        run: |
+          cargo check -p arrow --features simd --all-targets
+
+
+  # test the arrow crate builds against wasm32 in stable rust
+  wasm32-build:
+    name: Build wasm32
+    runs-on: ubuntu-latest
+    container:
+      image: amd64/rust
+      env:
+        # Disable full debug symbol generation to speed up CI build and keep memory down
+        # "1" means line tables only, which is useful for panic tracebacks.
+        RUSTFLAGS: "-C debuginfo=1"
+    steps:
+      - uses: actions/checkout@v3
+        with:
+          submodules: true
+      - name: Cache Cargo
+        uses: actions/cache@v3
+        with:
+          path: /github/home/.cargo
+          key: cargo-wasm32-cache3-
+      - name: Setup Rust toolchain for WASM
+        run: |
+          rustup toolchain install nightly
+          rustup override set nightly
+          rustup target add wasm32-unknown-unknown
+          rustup target add wasm32-wasi
+      - name: Build
+        run: |
+          cd arrow
+          cargo build --no-default-features --features=json,csv,ipc,simd,ffi --target wasm32-unknown-unknown
+          cargo build --no-default-features --features=json,csv,ipc,simd,ffi --target wasm32-wasi
+
+  clippy:
+    name: Clippy
+    runs-on: ubuntu-latest
+    container:
+      image: amd64/rust
+    steps:
+      - uses: actions/checkout@v3
+      - name: Setup Rust toolchain
+        uses: ./.github/actions/setup-builder
+        with:
+          rust-version: stable
+      - name: Setup Clippy
+        run: |
+          rustup component add clippy
+      - name: Run clippy
+        run: |
+          cargo clippy -p arrow --features=prettyprint,csv,ipc,test_utils,ffi,ipc_compression,dyn_cmp_dict --all-targets -- -D warnings