Skip to content

Commit

Permalink
Increase default timeout to 30 seconds (#4989)
Browse files Browse the repository at this point in the history
  • Loading branch information
tustvold authored Oct 25, 2023
1 parent c90aff3 commit a33d42f
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion object_store/src/client/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,9 @@ impl Default for ClientOptions {
// <https://docs.aws.amazon.com/sdkref/latest/guide/feature-smart-config-defaults.html>
// <https://docs.aws.amazon.com/whitepapers/latest/s3-optimizing-performance-best-practices/timeouts-and-retries-for-latency-sensitive-applications.html>
// Which recommend a connection timeout of 3.1s and a request timeout of 2s
//
// As object store requests may involve the transfer of non-trivial volumes of data
// we opt for a slightly higher default timeout of 30 seconds
Self {
user_agent: None,
content_type_map: Default::default(),
Expand All @@ -203,7 +206,7 @@ impl Default for ClientOptions {
proxy_excludes: None,
allow_http: Default::default(),
allow_insecure: Default::default(),
timeout: Some(Duration::from_secs(5).into()),
timeout: Some(Duration::from_secs(30).into()),
connect_timeout: Some(Duration::from_secs(5).into()),
pool_idle_timeout: None,
pool_max_idle_per_host: None,
Expand Down

0 comments on commit a33d42f

Please sign in to comment.