Skip to content

Commit

Permalink
arrow-ipc: Default to not preserving dict IDs
Browse files Browse the repository at this point in the history
  • Loading branch information
brancz committed Nov 25, 2024
1 parent 7fc0e87 commit a347a5f
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions arrow-ipc/src/writer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ pub struct IpcWriteOptions {
/// Flag indicating whether the writer should preserve the dictionary IDs defined in the
/// schema or generate unique dictionary IDs internally during encoding.
///
/// Defaults to `true`
/// Defaults to `false`
preserve_dict_id: bool,
}

Expand Down Expand Up @@ -112,7 +112,7 @@ impl IpcWriteOptions {
write_legacy_ipc_format,
metadata_version,
batch_compression_type: None,
preserve_dict_id: true,
preserve_dict_id: false,
}),
crate::MetadataVersion::V5 => {
if write_legacy_ipc_format {
Expand All @@ -125,7 +125,7 @@ impl IpcWriteOptions {
write_legacy_ipc_format,
metadata_version,
batch_compression_type: None,
preserve_dict_id: true,
preserve_dict_id: false,
})
}
}
Expand Down Expand Up @@ -161,7 +161,7 @@ impl Default for IpcWriteOptions {
write_legacy_ipc_format: false,
metadata_version: crate::MetadataVersion::V5,
batch_compression_type: None,
preserve_dict_id: true,
preserve_dict_id: false,
}
}
}
Expand Down Expand Up @@ -785,7 +785,7 @@ impl DictionaryTracker {
written: HashMap::new(),
dict_ids: Vec::new(),
error_on_replacement,
preserve_dict_id: true,
preserve_dict_id: false,
}
}

Expand Down

0 comments on commit a347a5f

Please sign in to comment.