Deprecate Fields::remove Schema::remove

apache · Nov 29, 2023 · c21349a · c21349a
1 parent ef6932f
commit c21349a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/arrow-schema/src/fields.rs b/arrow-schema/src/fields.rs
@@ -117,6 +117,8 @@ impl Fields {
     /// assert_eq!(fields.remove(1), Field::new("b", DataType::Int8, false).into());
     /// assert_eq!(fields.len(), 2);
     /// ```
+    #[deprecated(note = "Use SchemaBuilder::remove")]
+    #[doc(hidden)]
     pub fn remove(&mut self, index: usize) -> FieldRef {
         let mut builder = SchemaBuilder::from(Fields::from(&*self.0));
         let field = builder.remove(index);

diff --git a/arrow-schema/src/schema.rs b/arrow-schema/src/schema.rs
@@ -402,6 +402,9 @@ impl Schema {
     /// assert_eq!(schema.remove(1), Field::new("b", DataType::Int8, false).into());
     /// assert_eq!(schema.fields.len(), 2);
     /// ```
+    #[deprecated(note = "Use SchemaBuilder::remove")]
+    #[doc(hidden)]
+    #[allow(deprecated)]
     pub fn remove(&mut self, index: usize) -> FieldRef {
         self.fields.remove(index)
     }