Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make_primitive_scalar function loses DataType Internal information #4851

Closed
JasonLi-cn opened this issue Sep 23, 2023 · 1 comment · Fixed by #4852
Closed

make_primitive_scalar function loses DataType Internal information #4851

JasonLi-cn opened this issue Sep 23, 2023 · 1 comment · Fixed by #4852
Labels
arrow Changes to the arrow crate bug

Comments

@JasonLi-cn
Copy link
Contributor

Describe the bug

make_primitive_scalar function loses DataType Internal information.

Example:

Arg d is DataType::Timestamp(TimeUnit::Millisecond, Some("+08:00")), but the DataType of the return ScalarValue is DataType::Timestamp(TimeUnit::Millisecond, None), which loses the tz Some("+08:00").

To Reproduce

Expected behavior

The DataType of the return ScalarValue is DataType::Timestamp(TimeUnit::Millisecond, Some("+08:00"))

Additional context
@JasonLi-cn JasonLi-cn added the bug label Sep 23, 2023
@JasonLi-cn JasonLi-cn mentioned this issue Sep 23, 2023
Merged
@tustvold tustvold added the arrow Changes to the arrow crate label Oct 18, 2023
@tustvold
Copy link
Contributor

label_issue.py automatically added labels {'arrow'} from #4852

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: make_primitive_scalar bug JasonLi-cn/arrow-rs
2 participants
@tustvold @JasonLi-cn