Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make_primitive_scalar bug #4852

Merged
merged 1 commit into from
Sep 23, 2023

Conversation

JasonLi-cn
Copy link
Contributor

Which issue does this PR close?

Closes #4851

Rationale for this change

What changes are included in this PR?

Returns the exact DataType.

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Sep 23, 2023
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, to check my understanding is correct, this only impacts the deprecated comparison functions which make use of this function?

@JasonLi-cn
Copy link
Contributor Author

Makes sense to me, to check my understanding is correct, this only impacts the deprecated comparison functions which make use of this function?

You're right.

@tustvold tustvold merged commit 1de21d2 into apache:master Sep 23, 2023
ryanaston pushed a commit to segmentio/arrow-rs that referenced this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make_primitive_scalar function loses DataType Internal information
2 participants