Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object Store Doctest Failure with Default Features #5025

Closed
tustvold opened this issue Nov 2, 2023 · 1 comment · Fixed by #5161
Closed

Object Store Doctest Failure with Default Features #5025

tustvold opened this issue Nov 2, 2023 · 1 comment · Fixed by #5161
Labels
bug object-store Object Store Interface

Comments

@tustvold
Copy link
Contributor

tustvold commented Nov 2, 2023

Describe the bug

Running cargo test on the object_store crate result in a failing doctest

---- src/lib.rs - (line 105) stdout ----
error[E0432]: unresolved import `object_store::aws`
 --> src/lib.rs:109:19
  |
7 | use object_store::aws::{AmazonS3, AmazonS3Builder};
  |                   ^^^ could not find `aws` in `object_store`

This was introduced in #4978 and not caught by CI as we only test with all features

To Reproduce

Expected behavior

Additional context

#5024 worked around this for the purposes of release verification, and is also generally a more correct for the verification scripts to be doing.

@tustvold
Copy link
Contributor Author

tustvold commented Jan 5, 2024

label_issue.py automatically added labels {'object-store'} from #5161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug object-store Object Store Interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant