object_store: fix failing doctest with default features #5161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Worth introducing something like cargo hack into CI to test all features (and combinations) to try catch errors like this in future? |
Jefffrey
commented
Dec 3, 2023
Comment on lines
+72
to
+73
| rand = "0.8" | ||
| tempfile = "3.1.0" |
There was a problem hiding this comment.
Just reordering to respect the comment about order
I played with this a while back, the problem is testing all the feature combinations takes a very long time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5025
Rationale for this change
What changes are included in this PR?
Fix doctest to be encapsulated within block which depends on aws feature
Add block to doctest
Are there any user-facing changes?