-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass Options to HttpBuilder in parse_url_opts #5310
Comments
This could definitely be documented better but it should work to specify https://docs.rs/object_store/latest/src/object_store/aws/builder.rs.html#381 Values are parsed by https://docs.rs/humantime/latest/humantime/fn.parse_duration.html |
Thanks for looking at this. I'm wondering if it works with Http? I think this is the relevant object_store code--It seems all options are ignored in the Http case https://docs.rs/object_store/latest/src/object_store/parse.rs.html#136-180
(I also tried it with Http and it didn't seem to work.) |
Aah yes, it would appear #4516 did not update parse_url. Will get a fix up for you |
[Also added to the PR] You need to add line 167 back in or this fix doesn't work.
|
|
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Summary
I am trying to use
parse_url_opts
to create anObjectPath
andStorePath
completely from strings (and lists of string pairs). This will make it much easier for my users to access genomic data from the cloud. I can't, however, set the needed timeout option.Details
I love parse_url_opts. It lets me set options such as "aws_access_key_id".
It (apparently) does not, however, let me set client options such as "timeout". This is especially important for
Http.
Describe the solution you'd like
Perhaps the client options could be allowed and prefixed with "client_", for example,
Describe alternatives you've considered
Additional context
The text was updated successfully, but these errors were encountered: