Test parse_url_opts for HTTP (#5310) #5316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
force-pushed
the
test-http-url-parsing
branch
from
84f3f3f to
0396892
Compare
alamb
approved these changes
Jan 20, 2024
| Response::new(Body::empty()) | ||
| }); | ||
|
|
||
| let test = format!("{}/foo/bar", server.url()); |
There was a problem hiding this comment.
Can we also please document this test to explain the intent (which is that some options are passed as http headers?)
Also, would it be possible to document the behavior on parse_url_opts -- it doesn't mention anything about this behavior in the documentation that I can find:
https://docs.rs/object_store/latest/object_store/fn.parse_url_opts.html
There was a problem hiding this comment.
I will roll this into #5274
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5310
Rationale for this change
Follow up to #5311
What changes are included in this PR?
Are there any user-facing changes?