Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrow Flight SQL example server: do_handshake should include auth header #5665

Closed
istvan-fodor opened this issue Apr 18, 2024 · 2 comments · Fixed by #5666
Closed

Arrow Flight SQL example server: do_handshake should include auth header #5665

istvan-fodor opened this issue Apr 18, 2024 · 2 comments · Fixed by #5666
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@istvan-fodor
Copy link
Contributor

istvan-fodor commented Apr 18, 2024

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
We should include the authorization header in the do_handshake response.

Describe the solution you'd like
I would like to add the token in the auth header in the response. This is based on the discussion on [email protected] (see #5662)

@istvan-fodor istvan-fodor added the enhancement Any new improvement worthy of a entry in the changelog label Apr 18, 2024
@tustvold tustvold added the arrow Changes to the arrow crate label May 10, 2024
@tustvold
Copy link
Contributor

label_issue.py automatically added labels {'arrow'} from #5666

@tustvold tustvold added the arrow-flight Changes to the arrow-flight crate label May 10, 2024
@tustvold
Copy link
Contributor

label_issue.py automatically added labels {'arrow-flight'} from #5666

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants