-
Notifications
You must be signed in to change notification settings - Fork 838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arrow Flight SQL example JDBC driver incompatibility #5666
Arrow Flight SQL example JDBC driver incompatibility #5666
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me 👍
Cleaner type for response variable Co-authored-by: Jeffrey Vo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might have to separate the listening address vs the server address to make things clearer 🤔
Thoughts on this?
If you have FlightInfo return an empty location, clients can re-use the connection that was used for the GetFlightInfo request. This is useful for the case where returning this IP/host is non-trivial. |
I can add this change, and just return an empty list - it seems to me the best default case that makes sense for most users. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went ahead and added the change suggested by @jduo and removed location from the returned FlightEndpoint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
let addr_str = "0.0.0.0:50051"; | ||
let addr = addr_str.parse()?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let addr_str = "0.0.0.0:50051"; | |
let addr = addr_str.parse()?; | |
let addr = "0.0.0.0:50051".parse()?; | |
let svc = FlightServiceServer::new(FlightSqlServiceImpl {}); |
Minor nit, but we can revert to what it was previously (and down below too)
Which issue does this PR close?
Closes #5665
Closes #5669
Rationale for this change
It would be great if the example Flight SQL server would support integration with the Arrow JDBC driver. This would demonstrate the cross-platform nature of Arrow quite well.
This PR changes the example flight_sql_server so we can query it from Java using the Arrow JDBC driver.
What changes are included in this PR?
clear_token()
toFlightSqlServiceClient
to give the client the ability to re-authenticate.Are there any user-facing changes?
No