Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite FlightSQL client in terms of the mid level client (WIP) #3401

Closed
wants to merge 12 commits into from

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Dec 27, 2022

Draft as it builds on

Which issue does this PR close?

re #3301

closes #3310
closes #3308
closes #3400

Rationale for this change

Low level details such as encoding FlightData and specific forms of authentication should be avoided in FlightSQL as they are now present in the mid level client and so this client can be used with as many implementations as possible

What changes are included in this PR?

  1. Rewrites the FlightSQL client in terms of the Flight mid level client
  2. Adds a FlightSQL integration tests
  3. Adds CI coverage for flight-experimental features: Add CI test coverage for flight-sql-experimental features #3400
  4. TODO Move specifics of credential handling and connection management into examples client / server (e.g. handshake)

Are there any user-facing changes?

Yes; New FlightSqlClient (still behind XXXXX feature flag)

@github-actions github-actions bot added arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate labels Dec 27, 2022
@alamb
Copy link
Contributor Author

alamb commented Mar 2, 2023

This has bitrotted too much -- I will redo the code if we want to pursue the idea

@alamb alamb closed this Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate
Projects
None yet
1 participant