-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow concat_batches
to work with RecordBatch
es that have different metadata
#4800
Conversation
concat_batches
to work with RecordBatch
es that have different metadata
45da217
to
5fc2ea7
Compare
Is this not correct behaviour? If the metadata is inconsistent how does it know which metadata to preserve? |
@@ -204,13 +204,32 @@ pub fn concat_batches<'a>( | |||
RecordBatch::try_new(schema.clone(), arrays) | |||
} | |||
|
|||
/// Returns true if data with the `source` Schema can be placed in a | |||
/// record batch with `target` Schema | |||
fn concatable_schema(target: &Schema, source: &Schema) -> bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems similar to https://docs.rs/arrow-schema/latest/arrow_schema/struct.Schema.html#method.contains
Right now the To summarize a conversation I had with @tustvold over slack
I am sure I can fix my particular problem (see https://github.com/influxdata/influxdb_iox/pull/8691/files#r1319044861) other level of the stack (e.g in DataFusion) but it didn't feel right to me that |
See discussion on #4801 |
Conclusion of the discussion I think is that we would prefer to remove the error checking entirely. See #4815 |
Which issue does this PR close?
Resolves #4799
Rationale for this change
See Resolves #4799
What changes are included in this PR?
Are there any user-facing changes?
concat
will not error in as many cases