feat(datafusion-7181): enable slicing of rows #4817
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
reviewed
Sep 14, 2023
| offsets = offsets.iter_mut().map(|x| *x - start).collect(); | ||
|
|
||
| if length > 0 { | ||
| assert_eq!(offsets.last().unwrap(), &buffer.len()); |
There was a problem hiding this comment.
These are just sanity checks correct?
|
I believe the conclusion upstream is that we don't need this, so closing. Feel free to reopen if I have misunderstood |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This is a change required in order to slice the row cursor in the cascaded sort order.
precursor for apache/datafusion#7181
Rationale for this change
During the cascaded merge, we may yield partial record batch (a.k.a. partial cursors) from a given merge node (in the cascade tree). As such, the cursor would need to be sliced as described here.
What changes are included in this PR?
Slicing the cursor.
Are there any user-facing changes?
No breaking changes.
Only a new API
.slice()method, including documentation.