Fix merge_dictionary_values in selection kernels #4833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Sep 18, 2023
| ) -> BooleanBuffer { | ||
| let mut builder = BooleanBufferBuilder::new(keys.len()); |
There was a problem hiding this comment.
This is the bug, the length of the values_mask should match that of the values array not the keys. In all of the existing tests the number of keys outnumbered the number of values, not helped by the heuristic to trigger merging being based off the total number of keys outnumbering the total number of values.
alamb
approved these changes
Sep 18, 2023
| @@ -330,4 +333,15 @@ mod tests { | |||
| assert_eq!(&merged.key_mappings[0], &[0, 0, 0, 1, 0]); | |||
| assert_eq!(&merged.key_mappings[1], &[]); | |||
| } | |||
|
|
|||
| #[test] | |||
There was a problem hiding this comment.
I verified that without the changes in this PR this test fails like this:
thread 'dictionary::tests::test_merge_keys_smaller' panicked at 'assertion failed: `(left == right)`
left: `StringArray
[
]`,
right: `StringArray
[
"b",
]`', arrow-select/src/dictionary.rs:342:9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Added in #3558 this had a subtle bug in the way it was computing the values masks
Found by apache/datafusion#7587
What changes are included in this PR?
Are there any user-facing changes?