fix: object store http header last modified #4834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
reviewed
Sep 18, 2023
|
I need to think on this, it might be we need to loosen the requirements for HttpStore, ideally as a configurable option. However, as written this PR will loosen the requirements for things like S3, etc... which I'm not sure is a good idea |
That makes sense. I just pushed up a refactor that changes This should leave the other object stores like S3 unaffected. |
tustvold
approved these changes
Sep 19, 2023
Co-authored-by: Raphael Taylor-Davies <[email protected]>
Co-authored-by: Raphael Taylor-Davies <[email protected]>
Co-authored-by: Raphael Taylor-Davies <[email protected]>
ryanaston
pushed a commit
to segmentio/arrow-rs
that referenced
this pull request
Nov 6, 2023
* fix: object store http header last modified * refactor: make headermeta configurable on required fields * Update object_store/src/client/header.rs Co-authored-by: Raphael Taylor-Davies <[email protected]> * Update object_store/src/client/header.rs Co-authored-by: Raphael Taylor-Davies <[email protected]> * Update object_store/src/client/header.rs Co-authored-by: Raphael Taylor-Davies <[email protected]> --------- Co-authored-by: Raphael Taylor-Davies <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4831
Rationale for this change
object store 0.7.0 caused breaking changes in fetching from endpoints without
last_modifiedWhat changes are included in this PR?
If the
last-modifiedheader is not present, it will default to the epoch.Are there any user-facing changes?