Error if Remote Ignores HTTP Range Header #4841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
changed the title
tustvold
reviewed
Sep 20, 2023
Co-authored-by: Raphael Taylor-Davies <[email protected]>
ryanaston
pushed a commit
to segmentio/arrow-rs
that referenced
this pull request
Nov 6, 2023
* fix: abort http:get on !206 when issuing a range request * add some comments * pr feedback * Update object_store/src/http/client.rs Co-authored-by: Raphael Taylor-Davies <[email protected]> --------- Co-authored-by: Raphael Taylor-Davies <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4839
Rationale for this change
What changes are included in this PR?
If a range was requested and the server returned a 200 instead of a 206, we error out as it means that the server didn't fulfill the request.
Are there any user-facing changes?
this could cause some backwards incompatibility with previously working queries no longer working as we are now a bit stricter about what we are expecting.
Some examples that would no longer work
200.The latter example is the one this is aiming to prevent. If it can't fulfill the range request, we shouldn't continue on as nothing happened, we should error instead of overfetching data.