Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose csvbuilder has_headers #4906

Closed
wants to merge 1 commit into from

Conversation

fansehep
Copy link
Contributor

@fansehep fansehep commented Oct 9, 2023

Which issue does this PR close?

Closes #4735.

Rationale for this change

What changes are included in this PR?

expose the has_header.

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Oct 9, 2023
@tustvold
Copy link
Contributor

tustvold commented Oct 9, 2023

I think I would prefer that we add a new with_has_headers and deprecate the old has_headers then once this has percolated through a couple of releases we can potentially repurpose the has_headers to be an accessor.

@fansehep
Copy link
Contributor Author

fansehep commented Oct 9, 2023

I think I would prefer that we add a new with_has_headers and deprecate the old has_headers then once this has percolated through a couple of releases we can potentially repurpose the has_headers to be an accessor.我想我更愿意添加一个新的 with_has_headers 并弃用旧的 has_headers ,然后一旦它渗透到几个版本中,我们就可以重新调整 has_headers 的用途成为一个访问者。

I think I would prefer that we add a new with_has_headers and deprecate the old has_headers then once this has percolated through a couple of releases we can potentially repurpose the has_headers to be an accessor.

I think is_has_headers name is better than get_has_headers. Maybe we can now deprecate of it?

@tustvold
Copy link
Contributor

tustvold commented Oct 9, 2023

Alternative proposal in #4909 PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add read access to settings in csv::WriterBuilder
2 participants