Default connection and request timeouts of 5 seconds #4928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Oct 13, 2023
| pub(crate) fn metadata_client(&self) -> Result<Client> { | ||
| self.clone() | ||
| .with_allow_http(true) | ||
| .with_connect_timeout(Duration::from_secs(1)) |
There was a problem hiding this comment.
This will help new users who may use the crate without configuring any credentials, which will then default to the metadata credentials, which will then hang indefinitely trying to get credentials from a non-existent metadata endpoint
tustvold
force-pushed
the
default-client-timeouts
branch
from
7fc8ed9 to
e61a38d
Compare
crepererum
reviewed
Oct 13, 2023
| proxy_excludes: None, | ||
| allow_http: Default::default(), | ||
| allow_insecure: Default::default(), | ||
| timeout: Some(Duration::from_secs(5).into()), |
There was a problem hiding this comment.
Since there are with_{connection_}timeout methods that accepts Duration but not None, maybe add two new methods with_infinite_{connection_}timeout and with clear doc warnings? Otherwise there is no public way to set these options to None. If you NEVER want anyone to set this to None, then this shouldn't be an Option.
crepererum
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Infinite timeouts are surprising and can result in workloads hanging with no obvious cause.
This also configures a very low connection timeout for the metadata endpoint, to provide fast feedback should it be being erroneously used in an environment that doesn't support it
What changes are included in this PR?
Are there any user-facing changes?