Add ReaderBuilder::with_header for csv reader
#4949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
parquet
crepererum
approved these changes
Oct 18, 2023
alamb
changed the title
csv ReaderBuilder::with_header
alamb
changed the title
csv ReaderBuilder::with_headerReaderBuilder::with_header for csv reader
alamb
added
api-change
alamb
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
Thanks @tustvold and @crepererum
I verified the old method still exists, but is deprecated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
This makes it consistent with https://docs.rs/arrow-csv/latest/arrow_csv/reader/struct.Format.html#method.with_header and following #4909 consistent with WriterBuilder::with_header, as well as consistent with the other methods on ReaderBuilder - https://docs.rs/arrow-csv/latest/arrow_csv/reader/struct.ReaderBuilder.html
What changes are included in this PR?
Are there any user-facing changes?