Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ImdsManagedIdentityProvider in Azure Functions (#4976) #4977

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

tustvold
Copy link
Contributor

Which issue does this PR close?

Closes #4976

Rationale for this change

Tweaks the ImdsManagedIdentityProvider to not rely on a field that isn't consistently returned by all IMDS endpoints. Azure continues to achieve new innovative levels of inconsistency...

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the object-store Object Store Interface label Oct 23, 2023
@tustvold
Copy link
Contributor Author

@tahaum are you able to test this out?

@tustvold
Copy link
Contributor Author

I have confirmed this does not break the pre-existing support for virtual machines

@tustvold tustvold merged commit e79b3bc into apache:master Oct 23, 2023
13 checks passed
@tahaum
Copy link

tahaum commented Oct 24, 2023

@tustvold Thanks! Not sure how I can easily test this?

@tustvold
Copy link
Contributor Author

Aah I see you are using delta-rs via the python bindings, yeah that would be fiddly, I'll test this out before I cut the next release

@tahaum
Copy link

tahaum commented Oct 24, 2023

Ok, great! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
object-store Object Store Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure ImdsManagedIdentityProvider does not work in Azure functions
3 participants