Object tagging (#4754) #4999
Merged
Object tagging (#4754) #4999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Oct 27, 2023
object_store/src/lib.rs
Outdated
Comment on lines
1907
to
1910
| pub(crate) async fn tagging<F, Fut>(storage: &dyn ObjectStore, get_tags: F) | ||
| where | ||
| F: Fn(Path) -> Fut + Send + Sync, | ||
| Fut: Future<Output = Result<reqwest::Response>> + Send, |
There was a problem hiding this comment.
Honestly working out the correct combination of lifetimes and send and sync took longer than anything else in this PR... Sometimes I really dislike async...
tustvold
commented
Oct 27, 2023
object_store/src/aws/builder.rs
Outdated
| /// Supported keys: | ||
| /// - `aws_skip_tagging` | ||
| /// - `skip_tagging` | ||
| SkipTagging, |
There was a problem hiding this comment.
I don't feel strongly about this name
There was a problem hiding this comment.
Maybe DisableTagging
There was a problem hiding this comment.
but I don't feel strongly either :)
thinkharderdev
approved these changes
Oct 27, 2023
object_store/src/aws/builder.rs
Outdated
| /// Supported keys: | ||
| /// - `aws_skip_tagging` | ||
| /// - `skip_tagging` | ||
| SkipTagging, |
There was a problem hiding this comment.
Maybe DisableTagging
object_store/src/aws/builder.rs
Outdated
| /// Supported keys: | ||
| /// - `aws_skip_tagging` | ||
| /// - `skip_tagging` | ||
| SkipTagging, |
There was a problem hiding this comment.
but I don't feel strongly either :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4754.
Rationale for this change
Some stores support object tagging and this is important for existing workloads. Unfortunately support for this is not supported at all in some cases, e.g. GCS, and inconsistently supported in others, e.g. Azure and AWS-compatible stores.
What changes are included in this PR?
Are there any user-facing changes?