-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand parquet crate overview doc #5093
Conversation
This looks fantastic, thank you. I'm not at a computer currently, I'll double check things like formatting when I am, but from a quick read through the content looks 👌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for this, I moved some things around but what you wrote was already very good, I was just inspired to make some further changes
/// # use parquet::schema::printer::print_parquet_metadata; | ||
/// # async fn main() { | ||
/// // Populate configuration from environment | ||
/// let storage_container = Arc::new(MicrosoftAzureBuilder::from_env().build()?); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tweaked this to use from_env to cut down on boilerplate
As I've made some non-trivial modifications I intend to leave this open for until Monday, to give other reviewers time to comment |
Thanks! The update looks good to me. The one piece I would keep out would be the use of |
My intention was to focus on showing how to configure integration with object_store, not provide an exhaustive list of all the various ways one might configure it. |
Which issue does this PR close?
This is a doc-only update converting the discussions in #5064 and #2394 into docs. It closes neither of these PRs -- code fixes are needed for that.
Rationale for this change
The change clarifies which APIs are available in the parquet crate, what their intents are, how they relate to one-another, and which should be used when.
Are there any user-facing changes?
Doc update