Improve cast docs #5114
Merged
Improve cast docs #5114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Nov 22, 2023
| /// | ||
| /// Behavior: |
There was a problem hiding this comment.
These are moved just onto cast_with_options, as the duplication was leading to inconsistency
There was a problem hiding this comment.
The link to cast_with_options is a good idea
alamb
approved these changes
Nov 27, 2023
| /// | ||
| /// Behavior: |
There was a problem hiding this comment.
The link to cast_with_options is a good idea
| /// * Primitive to List: a list array with 1 value per slot is created | ||
| /// * Date32 and Date64: precision lost when going to higher interval | ||
| /// * Time32 and Time64: precision lost when going to higher interval | ||
| /// * Timestamp and Date{32|64}: precision lost when going to higher interval | ||
| /// * Temporal to/from backing primitive: zero-copy with data type change | ||
| /// * Casting from `float32/float64` to `Decimal(precision, scale)` rounds to the `scale` decimals |
There was a problem hiding this comment.
Suggested change
| /// * Casting from `float32/float64` to `Decimal(precision, scale)` rounds to the `scale` decimals | |
| /// * Casting from `float32/float64` to `Decimal(precision, scale)` rounds to `scale` decimals |
8 tasks
Co-authored-by: Andrew Lamb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
As pointed out on apache/datafusion#8302 the docs were misleading and incomplete
What changes are included in this PR?
Are there any user-facing changes?