feat: support cast between nested list and largelist #5121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewing cast_list_container the issue and why this check is present, is that it currently doesn't recurse and cast the value data. It took me a while to notice this, and I ended up getting quite nerd-sniped by this, so ended up just cleaning this logic up in #5124 PTAL |
tustvold
reviewed
Nov 26, 2023
| ))), | ||
| ) | ||
| .unwrap(); | ||
| let actual = list_array.as_any().downcast_ref::<ListArray>().unwrap(); |
There was a problem hiding this comment.
Can we please use AsArray in tests, i.e. .as_list::<i32>() it is much easier to read
| &array, | ||
| &DataType::List(Arc::new(Field::new( | ||
| "", | ||
| DataType::List(Arc::new(Field::new("", DataType::Int32, false))), |
There was a problem hiding this comment.
AFAICT this test simply ignores the nested list here, and is returning a non-nested list. This is consistent with my reading of cast_list_container
|
Closed in favor of #5124 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5113
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?