Cast from numeric/timestamp to timestamp/numeric #5123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
commented
Nov 25, 2023
| let array = Int64Array::from(vec![Some(2), Some(10), None]); | ||
| let expected = cast(&array, &DataType::Timestamp(TimeUnit::Microsecond, None)).unwrap(); | ||
|
|
||
| let array = Float32Array::from(vec![Some(2.0), Some(10.6), None]); |
There was a problem hiding this comment.
I don't add test for Float16Array as casting between Float16 and Int64 is not supported by cast kernel now. I will make it in a separate PR later.
tustvold
approved these changes
Nov 26, 2023
arrow-cast/src/cast.rs
Outdated
| @@ -1634,24 +1634,31 @@ pub fn cast_with_options( | |||
| .unary::<_, Time64MicrosecondType>(|x| x / (NANOSECONDS / MICROSECONDS)), | |||
| )), | |||
|
|
|||
| (Timestamp(TimeUnit::Second, _), _) if to_type.is_integer() => { | |||
| // Timestamp to integer/floating | |||
| (Timestamp(TimeUnit::Second, _), _) if to_type.is_integer() || to_type.is_floating() => { | |||
There was a problem hiding this comment.
Perhaps we could use is_numeric or is there a particular reason to exclude decimals?
There was a problem hiding this comment.
No, I plan to add decimals too (in a separate PR).
Let me add it here with test.
viirya
changed the title
tustvold
approved these changes
Nov 27, 2023
|
Seems to be a slight issue with can_cast_types |
This was referenced Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5122.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?