Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: split decimal cast #5126

Closed
wants to merge 2 commits into from
Closed

Conversation

fansehep
Copy link
Contributor

Which issue does this PR close?

Part of #5125

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Nov 27, 2023
Signed-off-by: fan <[email protected]>
@tustvold
Copy link
Contributor

Could we instead put the decimal module underneath cast, as described in the ticket. i.e. create a directory called cast and place it under that?

@fansehep
Copy link
Contributor Author

Could we instead put the decimal module underneath cast, as described in the ticket. i.e. create a directory called cast and place it under that?

I misunderstand the ticket. 😢

@tustvold tustvold marked this pull request as draft November 28, 2023 11:24
@tustvold
Copy link
Contributor

Marking as draft to signify this is not waiting on review, feel free to unmark when you would like me to take another look

@tustvold tustvold closed this Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants