feat(object_store): use http1 by default #5204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
approved these changes
Dec 12, 2023
object_store/src/client/mod.rs
Outdated
| self.http2_only = true.into(); | ||
| self | ||
| } | ||
|
|
||
| /// Use http2 if supported, otherwise use http1. | ||
| pub fn with_either_http1_http2(mut self) -> Self { |
There was a problem hiding this comment.
Suggested change
| pub fn with_either_http1_http2(mut self) -> Self { | |
| pub fn with_http2(mut self) -> Self { |
Perhaps?
Would also be good to add an option for this
object_store/src/gcp/mod.rs
Outdated
| //! Google Cloud Storage supports both HTTP/2 and HTTP/1. HTTP/1 is used by default | ||
| //! because it allows much higher throughput in our benchmarks (see | ||
| //! [#5194](https://github.com/apache/arrow-rs/issues/5194)). HTTP/2 can be | ||
| //! enabled by setting [crate::ClientConfigKey::Http2Only] to true. |
There was a problem hiding this comment.
Perhaps could add a key for HTTP2 to allow auto-upgrade if supported?
There was a problem hiding this comment.
I realized the easier advice is just to set Http1Only to false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5194.
Rationale for this change
This makes object store performance less surprising, by making the defaults the more performant options.
What changes are included in this PR?
Makes
HTTP1_ONLYthe default mode.Are there any user-facing changes?
This is a breaking change to defaults. However, user code generally will not need to change.