Split arrow_cast::cast::decimal into it's own submodule #5552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monkwire
commented
Mar 25, 2024
|
|
||
| /// Parses given string to specified decimal native (i128/i256) based on given | ||
| /// scale. Returns an `Err` if it cannot parse given string. | ||
| pub(crate) fn parse_string_to_decimal_native<T: DecimalType>( |
There was a problem hiding this comment.
I was hesitant to move this function into cast::decimal as there are plans for cast::string, and this function might be a better fit there. I ultimately chose to move this function because it returns a decimal, which seemed like a better fit for the decimal submodule.
monkwire
commented
Mar 25, 2024
| }) | ||
| } | ||
|
|
||
| pub(crate) fn string_to_decimal_cast<T, Offset: OffsetSizeTrait>( |
There was a problem hiding this comment.
Again, this might be a better fit for cast::string.
monkwire
commented
Mar 25, 2024
| } | ||
|
|
||
| /// Cast Utf8 to decimal | ||
| pub(crate) fn cast_string_to_decimal<T, Offset: OffsetSizeTrait>( |
There was a problem hiding this comment.
This may also be a better fit for cast::string.
tustvold
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR addresses part of #5125.
Rationale for this change
This PR moves the decimal handling logic from
arrow_cast::castinto private submodulearrow_cast::cast::decimal, makingarrow_cast::castsmaller and more manageable.What changes are included in this PR?
The decimal handling functions from
arrow_cast::castnow live inarrow_cast::cast::decimal, which is located atarrow-rs/arrow-cast/src/cast/decimal.rs.Are there any user-facing changes?
No.