Pin zstd-sys to v2.0.9 in parquet
#5567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebarron
reviewed
Mar 29, 2024
| @@ -53,6 +53,7 @@ brotli = { version = "3.3", default-features = false, features = ["std"], option | |||
| flate2 = { version = "1.0", default-features = false, features = ["rust_backend"], optional = true } | |||
| lz4_flex = { version = "0.11", default-features = false, features = ["std", "frame"], optional = true } | |||
| zstd = { version = "0.13.0", optional = true, default-features = false } | |||
| zstd-sys = { version = "=2.0.9", optional = true, default-features = false } | |||
There was a problem hiding this comment.
Maybe you should make a new feature zstd that turns on both the zstd and the zstd-sys features? Should this be a range for >=2.0,<2.10?
There was a problem hiding this comment.
Yeah that's a good point 👍
I was just doing some testing here so I'll clean it up as suggested
Edit: although, is it worth introducing a new feature for what will hopefully be a temporary fix? 🤔
Edit2: nvm, just needed to play with features a bit
tustvold
approved these changes
Mar 29, 2024
Updated in the code 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5565
Rationale for this change
Using
2.0.10causes parquet wasm build to fail. Can pin to2.0.9to have succeeding CI again, and maybe wait for upstream to fix issue with higher versions.What changes are included in this PR?
Are there any user-facing changes?