Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error message tests #5569

Merged
merged 1 commit into from
Mar 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions object_store/src/aws/builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1333,10 +1333,7 @@ mod tests {
.unwrap_err()
.to_string();

assert_eq!(
"Generic HTTP client error: builder error: unknown proxy scheme",
err
);
assert_eq!("Generic HTTP client error: builder error", err);
}

#[test]
Expand Down
4 changes: 2 additions & 2 deletions object_store/src/client/retry.rs
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,7 @@ mod tests {
}

let e = do_request().await.unwrap_err().to_string();
assert!(e.ends_with("too many redirects"), "{}", e);
assert!(e.contains("error following redirect for url"), "{}", e);

// Handles redirect missing location
mock.push(
Expand Down Expand Up @@ -489,7 +489,7 @@ mod tests {
let res = client.request(Method::PUT, mock.url()).send_retry(&retry);
let e = res.await.unwrap_err().to_string();
assert!(
e.contains("Error after 0 retries in") && e.contains("operation timed out"),
e.contains("Error after 0 retries in") && e.contains("error sending request for url"),
"{e}"
);

Expand Down
5 changes: 1 addition & 4 deletions object_store/src/gcp/builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -594,10 +594,7 @@ mod tests {
.unwrap_err()
.to_string();

assert_eq!(
"Generic HTTP client error: builder error: unknown proxy scheme",
err
);
assert_eq!("Generic HTTP client error: builder error", err);
}

#[test]
Expand Down
Loading