feat: JSON encoding of FixedSizeList
#5646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added ability to encode the FixedSizeList type in JSON. The implementation of FixedSizeListEncoder is very similar to that of ListEncoder, but is somewhat simpler, because of the constant offset. A test was added to verify behaviour of the JSON encoder with and without explicit nulls.
tustvold
reviewed
Apr 15, 2024
| let array = Arc::new(list_builder.finish()) as ArrayRef; | ||
| let batch = RecordBatch::try_new(schema, vec![array]).unwrap(); | ||
|
|
||
| //encode and check JSON with explicit nulls: |
|
@hiltontj thank you for doing this! I really appreciate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5568.
Rationale for this change
See #5568.
What changes are included in this PR?
Added ability to encode the
FixedSizeListtype in JSON via theFixedSizeListEncoder. The implementation ofFixedSizeListEncoderis very similar to that ofListEncoder, but is somewhat simpler, because of the constant offset.A test was added to verify behaviour of the JSON encoder with and without explicit nulls.
Are there any user-facing changes?
No.