Move ffi stream and utils from arrow to arrow-array #5670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
reviewed
Apr 22, 2024
tustvold
approved these changes
Apr 22, 2024
alexandreyc
force-pushed
the
move-ffi-stream
branch
from
71972cb to
4028316
Compare
|
CI is now green! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5663.
Rationale for this change
We have to depend on
arrowfor using the C Stream Interface for ADBC but we would prefer to depend on smaller crates. See apache/arrow-adbc#1725 (comment)Are there any user-facing changes?
I don't think so but please double check.
Notes
I had to remove usage of compute kernels within tests because this introduces a dev-dependency cycle (arrow-array <-> arrow-arith) which is problematic for the
Arraytrait. See https://doc.rust-lang.org/cargo/reference/resolver.html#dev-dependency-cyclesI had to redefine
Result<T> = std::result::Result<T, ArrowError>because it's only defined inarrow. Maybe we should move it toarrow_schemaalongsideArrowError.