Provide Arrow Schema Hint to Parquet Reader #5671
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
seems like the integration process has some problem |
tustvold
reviewed
Apr 20, 2024
| @@ -688,6 +688,32 @@ pub const DECIMAL256_MAX_SCALE: i8 = 76; | |||
| /// values | |||
| pub const DECIMAL_DEFAULT_SCALE: i8 = 10; | |||
|
|
|||
| // used for <https://github.com/apache/arrow-rs/pull/5605> we should decide what two different | |||
| // Datatype could be reinterpret | |||
| pub fn can_reinterpret(from_type: &DataType, to_type: &DataType) -> bool { | |||
There was a problem hiding this comment.
This appears to be duplicating the existing logic for schema jnference using the arrow schema as a hint, I'm not sure why we need this?
|
FYI there is another alternative idea here: #5939 which looks promising |
|
Closed by #5939 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5657
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?