Add more attributes to object_store::Attribute
#5690
Merged
+125
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5689.
What changes are included in this PR?
This PR adds
Attribute::ContentDisposition
,Attribute::ContentEncoding
andAttribute::ContentLanguage
and implements them for thehttp
,aws
,azure
andgcp
clients.Are there any user-facing changes?
Yes, the new aforementioned variants. However, as the enum is marked
#[non_exhaustive]
, this shouldn't be a breaking change.Note
I tried running the integration tests, but was unable to pass
gcs_test
andazure_blob_test
. However, I got exactly the same failures onmaster
.s3_test
passed, though another test from theaws
suite failed.I posted about this on Discord and would appreciate guidance or a fix to more thoroughly test this change.
Message text
Is the `CONTRIBUTING.md` for object_store outdated? None of the tests complete fully successfully for me, even on master, seemingly related to missing options or environment variables. AWS tests seem to be missing `EC2_METADATA_ENDPOINT`, Azure the container name and GCP a bucket name and private key ID.Attempting to manually provide the container name in the case of Azure (I'm assuming
test-bucket
leads to a test failure inazure_blob_test
: https://paste.debian.net/hidden/8b5a7f1f/Manually providing the missing options for GCP (adding a
private_key_id
field to the JSON and setting the bucket name) still leads to some test failures: https://paste.debian.net/hidden/05fec244/