Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more attributes to object_store::Attribute #5690

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

netthier
Copy link
Contributor

Which issue does this PR close?

Closes #5689.

What changes are included in this PR?

This PR adds Attribute::ContentDisposition, Attribute::ContentEncoding and Attribute::ContentLanguage and implements them for the http, aws, azure and gcp clients.

Are there any user-facing changes?

Yes, the new aforementioned variants. However, as the enum is marked #[non_exhaustive], this shouldn't be a breaking change.

Note

I tried running the integration tests, but was unable to pass gcs_test and azure_blob_test. However, I got exactly the same failures on master. s3_test passed, though another test from the aws suite failed.
I posted about this on Discord and would appreciate guidance or a fix to more thoroughly test this change.

Message text Is the `CONTRIBUTING.md` for object_store outdated? None of the tests complete fully successfully for me, even on master, seemingly related to missing options or environment variables. AWS tests seem to be missing `EC2_METADATA_ENDPOINT`, Azure the container name and GCP a bucket name and private key ID.

Attempting to manually provide the container name in the case of Azure (I'm assuming test-bucket leads to a test failure in azure_blob_test: https://paste.debian.net/hidden/8b5a7f1f/

Manually providing the missing options for GCP (adding a private_key_id field to the JSON and setting the bucket name) still leads to some test failures: https://paste.debian.net/hidden/05fec244/

Signed-off-by: netthier <[email protected]>
@github-actions github-actions bot added the object-store Object Store Interface label Apr 25, 2024
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, thank you

@tustvold tustvold merged commit 7feb542 into apache:master Apr 26, 2024
13 checks passed
@netthier netthier deleted the more-attributes branch April 26, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
object-store Object Store Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more attributes to object_store::Attribute
2 participants