-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BufWriter::with_attributes
and ::with_tags
in object_store
#5693
Conversation
Signed-off-by: netthier <[email protected]>
f2b7de3
to
0fd1427
Compare
We don't expose it publicly, as there is no consistency between stores, but there is an integration test of object tagging that you could hook into |
Could you maybe elaborate on how that hooking into could look like? If it's not too difficult I'd like to include it in this PR for completeness. |
https://github.com/apache/arrow-rs/blob/master/object_store/src/lib.rs#L2362 is an integration test called by both the AWS and Azure test suites, and is provided with a method for retrieving the tags for a given path. It should just be a case of extending this integration test with your new BufWriter functionality and that should do the trick |
I'm trying to add Any idea what I could do? EDIT: As both |
BufWriter::with_attributes
BufWriter::with_attributes
and ::with_tags
Signed-off-by: netthier <[email protected]>
6cdb175
to
0c030d7
Compare
BufWriter::with_attributes
and ::with_tags
BufWriter::with_attributes
and ::with_tags
in object_store
Which issue does this PR close?
Closes #5692.
What changes are included in this PR?
This PR adds the method
with_attributes
toBufWriter
, which allows users to set attributes on uploaded objects.I originally intended to addwith_tags
as well, as bothput_opts
andput_multipart_opts
support them, but I did not know how to retrieve tags after setting them, leaving me unable to test that method. Therefore I guess that this only closes the linked issue partially.It also adds
with_tags
which does the same but for tags.Are there any user-facing changes?
Yes, this PR introduces two new methods on
BufWriter
. There are no breaking changes though.