Fix PutPayloadMut::push not updating content_length (#5743) #5744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5743
Rationale for this change
PutPayloadMut was not correctly updating its content size, so WriteMultipart if solely used with
putwas incorrectly thinking that there was nothing to write and never uploading anything. Our existing tests always used a combination of push and extend_from_slice and so didn't run into this.As this is a pretty major bug introduced in 0.10.0, once merged I intend to prepare a patch release, and once cut will yank the broken release
What changes are included in this PR?
Are there any user-facing changes?