s3 region: Enable buckets that contain periods in their name for fetc… #5747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we possibly get a test for this? |
|
Just a thought - I note you’ve included a trailing / in the revised endpoint url. If I’m reading sdk/aws-smithy-runtime/src/client/endpoint.rs correctly then that trailing slash will get removed, so it would be better without it. |
|
Marking as draft while feedback (need for a test) is addressed. Please mark it as ready for review when it is ready for another look |
|
Closing as this PR has been inactive for a while |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hing region
Which issue does this PR close?
#5748
Closes #.
Rationale for this change
Currently we use the endpoint - let endpoint = format!("https://{}.s3.amazonaws.com", bucket);
This breaks down for buckets that have periods in them, since the certificates dont exist appropriately. By switching to the URL https://s3.amazonaws.com/{}/ we are able to ALSo support buckets with periods
Are there any user-facing changes?
No