Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment variable definitions to run the nanoarrow integration tests #5764

Merged
merged 3 commits into from
May 14, 2024

Conversation

paleolimbot
Copy link
Member

Which issue does this PR close?

Closes #5763.

Rationale for this change

It seems that the intention was to run nanoarrow's integration test suite (thanks!); however, the tests were not running.

What changes are included in this PR?

The requisite environment variable definitions were added for the tests to run.

Are there any user-facing changes?

No!

@paleolimbot paleolimbot changed the title maybe run the nanoarrow tests Add environment variable definitions to run the nanoarrow integration tests May 13, 2024
@tustvold
Copy link
Contributor

The intention wasn't necessarily to run them, but rather to have the CI tests actually run - there doesn't appear to be a way to not build nanoarrow 😆

That being said, if we can test against nanoarrow it can't hurt to do so 😄

@paleolimbot
Copy link
Member Author

I see! To do that you'd have to set ARCHERY_INTEGRATION_WITH_NANOARROW="0" (I can do that in this PR too if you'd rather). I agree that it's not very intuitive 🙂

@paleolimbot paleolimbot marked this pull request as ready for review May 13, 2024 14:55
@tustvold
Copy link
Contributor

Thank you

@tustvold tustvold merged commit 178ef99 into apache:master May 14, 2024
31 checks passed
@alamb alamb added the development-process Related to development process of arrow-rs label Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of arrow-rs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nanoarrow integration tests are being (unintentionally) skipped in CI
3 participants