Check length of FIXED_LEN_BYTE_ARRAY for uuid logical parquet type
#5821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
I want to add support to the
parquetcrate, so that parquet::arrow::arrow_to_parquet_schema and parquet::arrow::parquet_to_arrow_schema can roundtrip the canonicaluuidextension type.It seems the
PrimitiveTypeBuilderwas missing a length (16) check for theuuidlogical type. This PR adds the check, following the pattern used for other logical types that have a length requirement.What changes are included in this PR?
Adds a check for the length of a
PhysicalType::FIXED_LEN_BYTE_ARRAYwhen it's annotated withLogicalType::Uuid.Are there any user-facing changes?
The builder now returns an error if the length is not 16 when trying to annotate a
PhysicalType::FIXED_LEN_BYTE_ARRAYwithLogicalType::Uuid.